Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix select statement syntax for SQLAlchemy 2.0 #16421

Merged

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jul 19, 2023

Fix select syntax for SQLAlchemy 2.0. I missed 2 new cases while reviewing #16384. (there's one more, but that one is fixed in #16264)

Ref: #12541

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer labels Jul 19, 2023
@jdavcs jdavcs added this to the 23.1 milestone Jul 19, 2023
@jdavcs
Copy link
Member Author

jdavcs commented Jul 20, 2023

selenium failure unrelated

@bgruening bgruening merged commit 8c04ba9 into galaxyproject:release_23.1 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants