-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining legacy backbone form input elements #16834
Conversation
165c225
to
c208d5e
Compare
6d3a0b5
to
f448d49
Compare
90a36e7
to
5ac5968
Compare
…sh from library dataset name
…ata input instead
5ac5968
to
bf02dc9
Compare
There is a single tool on the tool shed actually, https://toolshed.g2.bx.psu.edu/view/damion/blast_reporting/812de0e282bd ... but it has the library_parm parameter commented:
so i'm pretty sure we're not breaking anything. I'm just gonna push a commit removing this from the schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@mvdbeek, thank you for your review and help! |
This PR removes the final two backbone-based form input elements, namely
ftpfile
andlibrary_data
.ftpfile
has only been used internally by the upload tool which uses a different UI and does not rely on the regular form components, hence the legacy backbone wrapper can simply be removed.After some discussion, and initially replacing the
library_data
input, we decided to remove this input since it's functionality is fully covered by the regular data input and it is not used on any of the public instances in addition to being unavailable in the toolshed. Thanks @mvdbeek for verifying that.Moving forward, neither of these two inputs should be used. Instead tool developers who would like to use ftp or library datasets as inputs should use the regular data input field. This field already allows users to select these types of datasets through the data dialog.
Additionally, this PR follows up by removing additional unused backbone legacy files.
How to test the changes?
(Select all options that apply)
License