Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining legacy backbone form input elements #16834

Merged
merged 17 commits into from
Oct 18, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Oct 11, 2023

This PR removes the final two backbone-based form input elements, namely ftpfile and library_data.

ftpfile has only been used internally by the upload tool which uses a different UI and does not rely on the regular form components, hence the legacy backbone wrapper can simply be removed.

After some discussion, and initially replacing the library_data input, we decided to remove this input since it's functionality is fully covered by the regular data input and it is not used on any of the public instances in addition to being unavailable in the toolshed. Thanks @mvdbeek for verifying that.

Moving forward, neither of these two inputs should be used. Instead tool developers who would like to use ftp or library datasets as inputs should use the regular data input field. This field already allows users to select these types of datasets through the data dialog.

Additionally, this PR follows up by removing additional unused backbone legacy files.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Oct 11, 2023
@guerler guerler added this to the 23.2 milestone Oct 11, 2023
@guerler guerler requested a review from mvdbeek October 11, 2023 19:23
@guerler guerler force-pushed the remaining_form_inputs branch from 165c225 to c208d5e Compare October 12, 2023 08:31
@guerler guerler force-pushed the remaining_form_inputs branch 2 times, most recently from 6d3a0b5 to f448d49 Compare October 12, 2023 11:12
@guerler guerler marked this pull request as ready for review October 12, 2023 14:24
@guerler guerler force-pushed the remaining_form_inputs branch 2 times, most recently from 90a36e7 to 5ac5968 Compare October 16, 2023 13:43
@guerler guerler force-pushed the remaining_form_inputs branch from 5ac5968 to bf02dc9 Compare October 17, 2023 07:29
@mvdbeek
Copy link
Member

mvdbeek commented Oct 17, 2023

Thanks @mvdbeek for verifying that.

There is a single tool on the tool shed actually, https://toolshed.g2.bx.psu.edu/view/damion/blast_reporting/812de0e282bd ... but it has the library_parm parameter commented:


                <!-- Disabled until Galaxy bug fixed for this.
                <param name="library_datasets" type="library_data" label="Reference Bin file" help="Select one reference bin at a time from the popup window's Reference Bin library."/>
                -->

so i'm pretty sure we're not breaking anything. I'm just gonna push a commit removing this from the schema.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@guerler guerler merged commit d8d27e8 into galaxyproject:dev Oct 18, 2023
@guerler guerler deleted the remaining_form_inputs branch October 18, 2023 10:52
@guerler
Copy link
Contributor Author

guerler commented Oct 18, 2023

@mvdbeek, thank you for your review and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants