Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve update history payload schema #18618

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Improve update history payload schema #18618

merged 2 commits into from
Jul 31, 2024

Conversation

davelopez
Copy link
Contributor

Part of #18532

Before After
image image

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Jul 30, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 30, 2024
@davelopez davelopez requested a review from a team July 30, 2024 10:44
mvdbeek
mvdbeek reviewed Jul 30, 2024
View reviewed changes
lib/galaxy/schema/schema.py Outdated
Comment on lines 1459 to 1464
# Potentially deprecated fields that are registered in the deserializer
# TODO: Expose or remove?
# user_rating: Optional[int] = None
# users_shared_with: Optional[List[DecodedDatabaseIdField]] = None


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for remove

@bgruening bgruening merged commit a716782 into galaxyproject:dev Jul 31, 2024
52 of 54 checks passed
@davelopez davelopez deleted the improve_update_history_payload_schema branch July 31, 2024 08:05
@davelopez davelopez mentioned this pull request Aug 9, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/API kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @mvdbeek @bgruening