Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement Tool Request API #18745

Closed
wants to merge 7 commits into from

Conversation

jmchilton
Copy link
Member

I've extracted the client pieces out of the structured state work (#17393). I think I would want to extract the workflow validation stuff out also before pulling this PR out of WIP. Some of this work is getting old - so I also need to update some of the SA idioms and break the migration out into its own commit.

Once polished, the immediate gain here is that sometimes the tool form submission can take several minutes to process. Think large collection map over jobs and such. We're creating 1000s of job objects in a web request and this is untenable. This API will allow us to just register a validated tool request in the database and let the job creation process happen within a Celery task. That will be a user experience improvement in the short term but in the long term these validated tool states will allow us to correct many technical issues with workflow extraction, job rerunning, etc.. We will always be able to recover what the user requested and how we processed the parameters - two things we just make guesses about right now (something something reproducibility).

See https://docs.google.com/document/d/1HQOLpLN54CjrB-wbD463XqzvUm-dNB8vTXUFBExh_2o/edit?usp=sharing.

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 28, 2024

This API will allow us to just register a validated tool request in the database and let the job creation process happen within a Celery task.

That's also a potential way forward to deal with database operation tools that require data in ok state, eventually

(something something reproducibility).

💯 🤣

@jmchilton jmchilton force-pushed the tool_request_api branch 3 times, most recently from 2821cb6 to 5bbf756 Compare September 1, 2024 19:01
@jmchilton jmchilton force-pushed the tool_request_api branch 14 times, most recently from c801c69 to 046dc0c Compare September 7, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants