-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle compressed content in dataset preview for all sequence classes #18776
Conversation
Thanks @PlushZ. Can you please run |
lib/galaxy/datatypes/sequence.py
Outdated
@@ -336,8 +336,43 @@ def split(cls, input_datasets: List, subdir_generator_function: Callable, split_ | |||
raise NotImplementedError("Can't split generic alignment files") | |||
|
|||
|
|||
class BaseSequence(Sequence): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class names should be the other way around, Base* something should be the thing you inherit from. I don't think there's a reason you could not push the display_data method right into the current Sequence class (and replace Sequence.display_data(self, trans, dataset, preview, filename, to_ext, **kwd)
with super().display_data(self, trans, dataset, preview, filename, to_ext, **kwd)
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for comment, I agreed and modified accordingly. As I understand, there is no need to pass self argument when using super() because it automatically passes self. But I don't know why the tests still use the version where self was explicitly passed, which leads to argument mismatches and results errors "too many arguments" in the method call. Removing self should resolve these errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all seems to be fine
Thanks @PlushZ! |
This PR fixes #15653
Method display_data moved to common class for fasta and fastq instead being used only in fasq class.
How to test the changes?
(Select all options that apply)
License