Do not skip CI tests on missing tools. #19002
Merged
+1
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
do_not_skip_ci_tests_on_missing_tools
branch
from
d9a7a89 to
d3e0e28
Compare
bgruening
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think you should have to send special flags to filter the API tests down for a particular version of Galaxy but I do think in CI we expect all of these tool to be available to it is appropriate to not skip when tools are missing. This also drops a test for a tool we seem to no longer have. I guess we removed library data parameters at some point - I vaguely recall that.
Uses the flat that was introduced in #18977.
How to test the changes?
(Select all options that apply)
License