Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Add galaxy metapackage for installing the latest stable version of Galaxy with pip install galaxy #19051

Draft
wants to merge 3 commits into
base: release_24.1
Choose a base branch
from

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Oct 23, 2024

This pins versions of all the galaxy* packages, but to mimic the current production best practice/run.sh, should we add all of pinned-requirements.txt? yes

I tried adding all of pinned-requirements.txt to install_requires but it fails because galaxy-data 24.1.2 (and all earlier versions of it) have a pin on social-auth-core==4.0.3 while the pinned-requirements.txt version for 24.1.2 is 4.5.4. We should unpin this in galaxy-data but it won't be possible to build a fully pinned galaxy metapackage until we unpin that and publish 24.1.3 packages.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    cd package/galaxy
    python -m build
    pip install --extra-index-url https://wheels.galaxyproject.org/simple ./dist/galaxy-24.1.2-py3-none-any.whl

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@natefoo natefoo changed the title Add galaxy metapackage for installing the latest stable version of Galaxy Add galaxy metapackage for installing the latest stable version of Galaxy with pip install galaxy Oct 23, 2024
@github-actions github-actions bot added this to the 24.2 milestone Oct 23, 2024
@natefoo natefoo force-pushed the pip-install-galaxy branch from 47c5d75 to 437acec Compare October 23, 2024 21:56
@natefoo natefoo changed the base branch from dev to release_24.1 October 23, 2024 21:57
@natefoo natefoo changed the title Add galaxy metapackage for installing the latest stable version of Galaxy with pip install galaxy [24.1] Add galaxy metapackage for installing the latest stable version of Galaxy with pip install galaxy Oct 23, 2024
@natefoo natefoo marked this pull request as draft October 24, 2024 17:27
@jdavcs jdavcs modified the milestones: 24.2, 25.0 Nov 20, 2024

[options]
include_package_data = True
install_requires =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tools to keep this up to date ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I guess it should be part of the package release process?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this could be handled as part of create_point_release in https://github.com/galaxyproject/galaxy-release-util/blob/main/galaxy_release_util/point_release.py#L597
Is this is a subset of pinned-requirements.txt? (I assume it's the difference between that and the union of requirements for all other packages?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ and I can add that to galaxy-release-util unless you'd like to handle it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natefoo natefoo force-pushed the pip-install-galaxy branch from 437acec to 50311f3 Compare December 6, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants