Migrate WorkflowEditor to TypeScript #19246
Draft
+1,054
−1,057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes licenseId and inputLicense to optional types Updates event emission to handle optional license (no license)
Changes the type of the 'transform' parameter in the defaultPosition function to use a more specific type, improving type safety and clarity.
Refactors WorkflowEditor component to use Vue 3's script setup syntax Improves route query handling and editor configuration loading
Introduces a function to fetch query parameter values from the route. Utilizes Vue Router's useRoute composable for accessing query parameters.
Migrates the Workflow Editor component to use the script setup and typescript syntax for improved maintainability, readability and performance. Replaces BootstrapVue components with their corresponding B-prefixed versions.
Changes saveWorkflow to accept id and workflow separately Simplifies request data construction and error handling
Changes the save button selector to use a more specific ID-based selector.
itisAliRH
force-pushed
the
workflow-editor-ts-migration
branch
from
d875a20 to
beec878
Compare
Replaces 'any' type with 'Wrapper<Vue>' for better type safety Removes redundant tests and properties Drop the not possible old tests
itisAliRH
force-pushed
the
workflow-editor-ts-migration
branch
from
beec878 to
a4f9022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the Workflow Editor component to utilize TypeScript and composition API syntax tio improve readabilty, type safty and maintance.
How to test the changes?
(Select all options that apply)
License