Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations improvements #19442

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Type annotations improvements #19442

merged 4 commits into from
Jan 23, 2025

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jan 21, 2025

Also:

  • Make InstallationTarget a runtime-checkable protocol
  • Reuseinstalled_repository_manager attribute instead of instantiating a InstalledRepositoryManager in several places.
  • Fix typos
  • Proper subclassing of ModelManager generic class

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jan 21, 2025
@github-actions github-actions bot added this to the 25.0 milestone Jan 21, 2025
@nsoranzo nsoranzo requested a review from a team January 21, 2025 17:44
@nsoranzo
Copy link
Member Author

Test failures unrelated.

@nsoranzo nsoranzo force-pushed the type_annot branch 2 times, most recently from 86fea60 to 2dac49b Compare January 22, 2025 12:54
Also:
- Reuse its `installed_repository_manager` attribute instead of
  instantiating a `InstalledRepositoryManager` in several places.
@nsoranzo
Copy link
Member Author

Pushed a couple of more changes. Test failures still unrelated.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nsoranzo for the nice type improvements!

@nsoranzo nsoranzo merged commit e2636d7 into galaxyproject:dev Jan 23, 2025
52 of 56 checks passed
@nsoranzo nsoranzo deleted the type_annot branch January 23, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/testing area/tool-framework kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants