Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles S3 listing errors #19446

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Handles S3 listing errors #19446

merged 1 commit into from
Jan 28, 2025

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Jan 22, 2025 •
edited
Loading

Closes #19445
Adds exception handling for S3 bucket listing to provide clearer error messages when listing fails.
image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Open a object store which has an invalid key

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH
Handles S3 listing errors
6718c01 
Adds exception handling for S3 bucket listing to provide clearer error messages when listing fails.
@github-actions github-actions bot added this to the 25.0 milestone Jan 22, 2025
@jmchilton jmchilton merged commit a8b1646 into galaxyproject:dev Jan 28, 2025
54 of 58 checks passed
@itisAliRH itisAliRH deleted the s3fs-list-error-improvment branch January 29, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/backend kind/enhancement
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.

500 error when the object store key is not valid
2 participants
@itisAliRH @jmchilton