[24.2] List private file sources first in Remote Files Dialog #19455
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a pretty limited fix to something that's arguably a bug of a pretty new feature, do you mind targeting 24.2 ? |
mvdbeek
approved these changes
Jan 24, 2025
|
Sure! I'll target 24.2 |
davelopez
force-pushed
the
list_private_file_sources_first
branch
from
36c828b to
5a016c3
Compare
github-actions
bot
changed the title
mvdbeek
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19438
The simplest way of addressing this is to list the user-defined sources at the top. We can think of more fancy ways to display this after consolidating these dialogs with Data Libraries, etc.
How to test the changes?
License