Various improvements for the log operators #401
+90
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lesquoyb
commented
Jan 20, 2025
lesquoyb
commented
- adds log operators for any base
- fixes wrong warning messages (addresses partly [code] runtime errors and warnings are often directly thrown in the code instead of passing through reportAndThrowIfNeeded #398)
- makes the warnings non-blocking : log will return -Infinity in case of wrong operands as is default in java
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -18,6 +18,7 @@ | |||
| import gama.annotations.precompiler.GamlAnnotations.test; | |||
| import gama.annotations.precompiler.GamlAnnotations.usage; | |||
| import gama.core.common.interfaces.IKeyword; | |||
| import gama.core.runtime.GAMA; | |||
There was a problem hiding this comment.
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 82.95% to 81.56%, threshold = 30.0%
Jarakoto
added a commit
to LOFT-Openlab/gama
that referenced
this pull request
Jan 26, 2025
Add a "describe" gama server command to get a model description which gives : - The species names and related actions - The experiments and related parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.