Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Safari logos not showing on home page #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Safari logos not showing on home page #495

wants to merge 1 commit into from

Conversation

GabLeRoux
Copy link
Member

@GabLeRoux GabLeRoux commented Jan 15, 2025 •
edited by coderabbitai bot
Loading

Closes #493

This pull request includes a small change to the src/components/pages/home/section/getting-started.tsx file. The change modifies the className property of the Link component to use a CSS grid layout instead of flexbox.

CleanShot 2025-01-15 at 18 38 52@2x

Summary by CodeRabbit

  • Style
    • Updated button layout to use grid-based centering for improved visual alignment and responsiveness.

@GabLeRoux
fix: Update LinkButton styling to use grid layout
9e8eb0d 
Update the LinkButton component in the GettingStarted section of the home page.
Change the className attribute to use grid instead of flex.

This prevents a bug on Safari where the logos would not render.
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2025 •
edited
Loading

Walkthrough

The pull request modifies the getting-started.tsx component, specifically changing the layout approach for a LinkButton from using flex to grid with place-items-center. This adjustment aims to improve the alignment and centering of button contents, potentially addressing layout inconsistencies across different browsers.

Changes

File Change Summary
src/components/pages/home/section/getting-started.tsx Modified className of Link component from flex to grid layout

Assessment against linked issues

Objective Addressed Explanation
Fix logo display issues on Safari [#493] ❓ Layout change might help, but cannot conclusively determine full resolution without visual testing

Poem

🐰 A rabbit's grid of code so neat,
Centering buttons with a clever feat
Safari's logos now aligned just right
With place-items-center, a coding delight!
Hop to perfection, pixel by pixel 🌈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

Cat Gif

@GabLeRoux GabLeRoux changed the title fix: Update LinkButton styling to use grid layout Fix Safari logos not showing Jan 15, 2025
@GabLeRoux GabLeRoux changed the title Fix Safari logos not showing Fix Safari logos not showing on home page Jan 15, 2025
@GabLeRoux GabLeRoux enabled auto-merge (squash) January 15, 2025 23:39
@GabLeRoux GabLeRoux self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 9e8eb0d):

https://game-ci-5559f--pr495-fix-safari-getting-s-dzz9eow9.web.app

(expires Wed, 22 Jan 2025 23:41:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b

coderabbitai[bot]
coderabbitai bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/pages/home/section/getting-started.tsx (1)

32-35: Consider adding accessibility attributes to the Link component.

While the styling looks great, we could enhance accessibility for screen readers by adding:

  • An aria-label to describe the action
  • A role="button" since it's styled as a button
 <Link
   to={url}
+  role="button"
+  aria-label={`Get started with ${url.split('/')[2]}`}
   className="group grid place-items-center border-gray-600 border-solid rounded-sm border-2 px-6 py-3 w-[180px] h-[70px] transition-all duration-200 hover:scale-110 hover:bg-gray-600"
 >
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92691c9 and 9e8eb0d.

📒 Files selected for processing (1)
  • src/components/pages/home/section/getting-started.tsx (1 hunks)
🔇 Additional comments (1)
src/components/pages/home/section/getting-started.tsx (1)

33-33: Excellent improvement to the button layout!

The switch from flex to grid with place-items-center is a great choice here. This approach:

  • Provides more reliable centering behavior
  • Reduces the number of required CSS properties
  • Maintains consistent alignment across different browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@GabLeRoux GabLeRoux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub, GitLab and CircleCI logos for call to action buttons are not showing properly on Safari
1 participant
@GabLeRoux