Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify round 3 #28

Merged
merged 2 commits into from
Mar 14, 2023
Merged

chore: clarify round 3 #28

merged 2 commits into from
Mar 14, 2023

Conversation

taramakage
Copy link
Member

No description provided.

@taramakage taramakage requested a review from efushigi March 14, 2023 07:11
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Also one more thing I still don't understand: how will we know the class-id and nft-ids? Essentially: how do we find our airdrops? :) (And what I think some people are concerned about, will they have enough time to find them and prepare the sending sequence)

README.md Outdated
@@ -135,11 +136,9 @@ Started from **Mar 13**

#### **Round 3: Competitive Individual Race**

Participants receive NFT airdrops on IRISnet and perform Interchain NFT Transfer through specified flows in Task Data. The airdrop has two rounds: In the first round, all participants go through the same flow, and in the second round, all participants go through different flows.
In this round, participants will receive NFT airdrops on IRISnet. Each NFT contains `Task Data` in its token data, which includes a `flow` field with a corresponding `flow-id` value that can be used to query the actual flow [in flow table](https://github.com/game-of-nfts/gon-testnets/blob/main/doc/flow-table.md). Participants can then perform Interchain NFT Transfer using the specified flows. After completing the interchain NFT transfer, each participant must transfer that NFT to the `last_owner` and then complete the race.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last part: "and then complete the race.", do you actually mean that there is anything left to do after transfering to last_owner, or is transferring to last_owner completing the race?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transfer to last_owner is the last thing you need to do. Just keep your tx hash for evidence.

Copy link

@giansalex giansalex Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taramakage does it mean that an IBC transfer to las_owner is invalid? i need to use TransferNFT '

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taramakage does it mean that an IBC transfer to las_owner is invalid? i need to use TransferNFT '

Thanks for noticing this! Do IBC transfer to your iris address first, then transfer that NFT to the last owner. For example:

IBC transfer:  iris-addr -> juno-addr -> stars-addr -> uptick-addr -> iris-addr (your iris-addr receives that interchain nft)

transfer ownership on iris:  iris-addr -> last-owner (finish this step then complete the race)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taramakage does it mean that an IBC transfer to las_owner is invalid? i need to use TransferNFT '

Thanks for noticing this! Do IBC transfer to your iris address first, then transfer that NFT to the last owner. For example:

IBC transfer:  iris-addr -> juno-addr -> stars-addr -> uptick-addr -> iris-addr (your iris-addr receives that interchain nft)

transfer ownership on iris:  iris-addr -> last-owner (finish this step then complete the race)

Ok, thanks.

README.md Outdated
- The `last_owner` is an official address on IRISnet. After finishing the interchain NFT transfer, every participant transfer the NFT to `last_owner` then complete the race.
- Considering the time zone difference, the completion time is calculated by the difference in height between the last NFT transfer (to the `last_owner`) and the first interchain NFT transfer on IRISnet.

- The `start_height` is the block height on IRISnet. Any transfer prior to the `start_height` will be considered invalid, which means your first Interchain NFT Transfer must happen after that height.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't know what the start_height will be, will we have enough time after the airdrop to actually prepare or will the start_height be so soon after the airdrop that this needs to be scripted?
Especially considering time-zone differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does start_time simply mean "start after block"? As long as you start after block it is fine? I am asking because of the time-difference comment below.

I guess the confusion is because this is considered a race, and start_height sounds like when we should start :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to set start_height as the height around the aridrop time. Considering the time zone we use the block height to replace the real time. Note start_height only means your first interchain transfer tx will be considered valid after that height, the real first transfer time is up to you.

start_height = 10000

first_interchain_transfer = 13000

last_transfer_to_last_owner = 13500

your difference of height is 13500-13000 == 500, and that's your grade

end_height = 20000 (suppose it's 20000; in fact, it will be the block height of IRIS at 03-17-23:59:59)

Invalid exmaple 1:

first_interchain_transfer = 9000  (you jumped the gun, you won't get points from B1~B4)
start_height = 10000

Invalid exmaple 2:

start_height = 10000

first_interchain_transfer = 13000

end_height = 20000

last_transfer_to_last_owner = 20001 ( we don't rank you, but you still get points from B1 and B2)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does start_time simply mean "start after block"? As long as you start after block it is fine? I am asking because of the time-difference comment below.

I guess the confusion is because this is considered a race, and start_height sounds like when we should start :D

Do you have any suggestion on its(start_height) naming?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about start_after_height?

README.md Outdated
- The end of round 3 will be at `2023-03-17-23:59:59 UTC`. The height of evidence will be considered invalid if completed after the corresponding block height.
- Participants must use their own account addresses provided at the registration stage.
- The third round of the competition will conclude at `2023-03-17 23:59:59 UTC`. After this, you can still complete B1 and B2, but your race rank will not be counted, and you will not be eligible to win B3 and B4.
- The top 10 participants in each airdrop round will be awarded B3 and B4 points.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some people asking about B3 and B4 since it is not in the evidence.xslx, maybe point out that we are not supposed to fill in anything for B3 and B4 ourselves?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From B1 and B2 evidence, we calculate your difference in height. Then we rank all these differences and pick up only the top 10 participants as the winners in B3 and B4.

@taramakage
Copy link
Member Author

Some comments. Also one more thing I still don't understand: how will we know the class-id and nft-ids? Essentially: how do we find our airdrops? :)

Good question. class-id and nft-ids will be released at gon-evidence#460.

@taramakage taramakage merged commit d8424cc into main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants