Backward compatible with even older PyTorch #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #551 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 2141 2141
=========================================
Hits 2141 2141 ☔ View full report in Codecov by Sentry. |
|
2021 is like 4 years ago and we don't really care about that anymore. |
|
Understood. I can patch the lib locally for my usecase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traceNamewas added in pytorch/kineto#458.viztracerdoes not need the field, so it's safe skip dropping the field if the field was just not there. I verified that it works with PyTorch 1.11.