bugfix: all outstanding issues identified by deepsource (#22)

* fix: remove outdated skipcq comments Signed-off-by: Gaukas Wang <[email protected]> * fix: combine append call for performance Signed-off-by: Gaukas Wang <[email protected]> * fix: ignore high cyclomatic complexity warning Signed-off-by: Gaukas Wang <[email protected]> --------- Signed-off-by: Gaukas Wang <[email protected]>
gaukas · Jun 3, 2024 · 3f06ffa · 3f06ffa
1 parent 05070a8
commit 3f06ffa
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/internal/utils/typeconv.go b/internal/utils/typeconv.go
@@ -3,8 +3,7 @@ package utils
 func Uint16ToUint8(a []uint16) []uint8 {
 	b := make([]uint8, 0)
 	for _, v := range a {
-		b = append(b, uint8(v>>8))
-		b = append(b, uint8(v))
+		b = append(b, uint8(v>>8), uint8(v))
 	}
 	return b
 }
diff --git a/quic_client_initial.go b/quic_client_initial.go
@@ -10,8 +10,6 @@ import (
 	"time"
 )
 
-// skipcq: GSC-G505
-
 type ClientInitial struct {
 	Header     *QUICHeader `json:"header,omitempty"` // QUIC header
 	FrameTypes []uint64    `json:"frames,omitempty"` // frames ID in order

diff --git a/quic_transport_parameters.go b/quic_transport_parameters.go
@@ -43,7 +43,7 @@ type QUICTransportParameters struct {
 // TLS Extension "QUIC Transport Parameters" (57)
 //
 // If any error occurs, the returned struct will have parseError set to the error.
-func ParseQUICTransportParameters(extData []byte) *QUICTransportParameters {
+func ParseQUICTransportParameters(extData []byte) *QUICTransportParameters { // skipcq: GO-R1005
 	qtp := &QUICTransportParameters{
 		parseError: errors.New("unknown error"),
 	}