Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: all outstanding issues identified by deepsource #22

Merged
merged 3 commits into from
Jun 3, 2024
Merged

bugfix: all outstanding issues identified by deepsource #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fab927
fix: remove outdated skipcq comments
gaukas Jun 3, 2024
c64cfd5
fix: combine append call for performance
gaukas Jun 3, 2024
c01ef0f
fix: ignore high cyclomatic complexity warning
gaukas Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/utils/typeconv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ package utils
func Uint16ToUint8(a []uint16) []uint8 {
b := make([]uint8, 0)
for _, v := range a {
b = append(b, uint8(v>>8))
b = append(b, uint8(v))
b = append(b, uint8(v>>8), uint8(v))
}
return b
}
2 changes: 0 additions & 2 deletions quic_client_initial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import (
"time"
)

// skipcq: GSC-G505

type ClientInitial struct {
Header *QUICHeader `json:"header,omitempty"` // QUIC header
FrameTypes []uint64 `json:"frames,omitempty"` // frames ID in order
Expand Down
2 changes: 1 addition & 1 deletion quic_transport_parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type QUICTransportParameters struct {
// TLS Extension "QUIC Transport Parameters" (57)
//
// If any error occurs, the returned struct will have parseError set to the error.
func ParseQUICTransportParameters(extData []byte) *QUICTransportParameters {
func ParseQUICTransportParameters(extData []byte) *QUICTransportParameters { // skipcq: GO-R1005
qtp := &QUICTransportParameters{
parseError: errors.New("unknown error"),
}
Expand Down
Loading