Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Host header before modifying in get_domain() #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Copy Host header before modifying in get_domain() #15

wants to merge 1 commit into from

Conversation

mocmocamoc
Copy link

At the moment get_domain() will strip the port number from the original Host header, meaning that subsequent functions that use the header will find it missing the port number. For example, redirect() calls get_domain() before itself retrieving the Host header, so the port number will always be gone before redirect() can get it.

@ronisaacson
Copy link

This is a valid issue, but a better fix is:

domain = apr_pstrdup(r->pool, domain);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants