Don't install CMakeLists.txt #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #449 +/- ##
============================================
Coverage 78.52% 78.52%
============================================
Files 72 72
Lines 9244 9244
============================================
Hits 7259 7259
Misses 1985 1985 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mjcarroll
approved these changes
Oct 10, 2022
Merged
scpeters
added a commit
that referenced
this pull request
Oct 11, 2022
This was unintentionally added in #449 and breaks compilation on case-insensitive filesystems. Signed-off-by: Steve Peters <[email protected]>
8 tasks
mjcarroll
pushed a commit
that referenced
this pull request
Oct 11, 2022
This was unintentionally added in #449 and breaks compilation on case-insensitive filesystems. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to gazebosim/gz-physics
that referenced
this pull request
Dec 1, 2022
Similar to gazebosim/gz-common#449. Signed-off-by: Steve Peters <[email protected]>
8 tasks
scpeters
added a commit
to gazebosim/gz-physics
that referenced
this pull request
Dec 1, 2022
Similar to gazebosim/gz-common#449. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes unstable 3.15.0 debbuild issue
Summary
Many of the 3.15.0 debbuilds were unstable:
The
profilercomponent was installing itsCMakeLists.txtfile, probably due to an issue with #418. This changes theCMakeLists.txtpattern to match theeventscomponent.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.