Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Port: Disable tests that are known to fail on Windows (#387) #394

Closed
wants to merge 1 commit into from
Closed

Forward Port: Disable tests that are known to fail on Windows (#387) #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/FuelClient_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,8 @@ TEST_F(FuelClientTest, DownloadWorld)
/////////////////////////////////////////////////
// Windows doesn't support colons in filenames
// https://github.com/gazebosim/gz-fuel-tools/issues/106
TEST_F(FuelClientTest, CachedWorld)
// This is fixed in gz-fuel-tools9+, but not here to preserve behavior
TEST_F(FuelClientTest, GZ_UTILS_TEST_DISABLED_ON_WIN32(CachedWorld))
{
ClientConfig config;
config.SetCacheLocation(common::joinPaths(common::cwd(), "test_cache"));
Expand Down Expand Up @@ -1476,8 +1477,11 @@ TEST_F(FuelClientTest, UploadModelFail)
EXPECT_EQ(ResultType::UPLOAD_ERROR, result.Type());
}

//////////////////////////////////////////////////
TEST_F(FuelClientTest, PatchModelFail)
/////////////////////////////////////////////////
// Windows doesn't support colons in filenames
// https://github.com/gazebosim/gz-fuel-tools/issues/106
// This is fixed in gz-fuel-tools9+, but not here to preserve behavior
TEST_F(FuelClientTest, GZ_UTILS_TEST_DISABLED_ON_WIN32(PatchModelFail))
{
FuelClient client;
ModelIdentifier modelId;
Expand Down
4 changes: 4 additions & 0 deletions src/gz_src_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ class CmdLine : public ::testing::Test
// instead of on teardown leaves the folder intact for debugging if needed
common::removeAll(testCachePath);
ASSERT_TRUE(common::createDirectories(testCachePath));
ASSERT_TRUE(common::createDirectories(
common::joinPaths(testCachePath, "fuel.gazebosim.org")));
ASSERT_TRUE(common::createDirectories(
common::joinPaths(testCachePath, "fuel.ignitionrobotics.org")));
setenv("GZ_FUEL_CACHE_PATH", this->testCachePath.c_str(), true);
}

Expand Down