Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-fuel-tools7 ➡️ gz-fuel-tools8 #401

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jan 18, 2024

➡️ Forward port

Port ign-fuel-tools7 ➡️ gz-fuel-tools8

Branch comparison: gz-fuel-tools8...ign-fuel-tools7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey and others added 7 commits November 13, 2023 10:17
* Use on `push` only on stable branches to avoid duplicate runs
* Update project automation

Signed-off-by: Addisu Z. Taddese <[email protected]>
* Use on `push` only on stable branches to avoid duplicate runs
* Update project automation

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-fuel-tools4 ➡️  ign-fuel-tools7
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from nkoenig as a code owner January 18, 2024 21:32
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 18, 2024
@azeey azeey requested a review from caguero January 19, 2024 17:24
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks very innocent, is CI supposed to fail?

@azeey
Copy link
Contributor Author

azeey commented Jan 19, 2024

The failing test is calling gz fuel list -t model, which fetches the entire list of models on Fuel. I'm guessing there was a network flakiness that caused the test to fail, but generally, I'm not sure if it's a good idea to fetch the entire list since the number of models will continue to grow. For now, I'll retry the jobs and see what happens.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed334c9) 75.32% compared to head (2c84439) 75.32%.

Additional details and impacted files
@@               Coverage Diff               @@
##           gz-fuel-tools8     #401   +/-   ##
===============================================
  Coverage           75.32%   75.32%           
===============================================
  Files                  20       20           
  Lines                2910     2910           
===============================================
  Hits                 2192     2192           
  Misses                718      718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey requested a review from caguero January 22, 2024 18:53
@azeey azeey merged commit 1896341 into gazebosim:gz-fuel-tools8 Jan 22, 2024
12 checks passed
@azeey azeey deleted the 7_to_8 branch January 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants