Fix miscellaneous issues and warnings #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Binding loop warning in WorldStats
- ImageDisplay warning stating that the image source is invalid
- This happened because the provider is being initialized in
LoadConfig which runs after the QML has been loaded. The solution
was to move it to the constructor. However, it depends on a unique
name obtained from the QML, which causes a chicken and egg problem.
To fix this, I've opted for generating a random string based on a
UUID number.
Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
requested changes
Jan 29, 2025
| @@ -51,19 +54,32 @@ class ImageDisplay::Implementation | |||
|
|
|||
| /// \brief To provide images for QML. | |||
| public: ImageProvider *provider{nullptr}; | |||
|
|
|||
| /// \brief Holds the provider name unique to this plugin instance | |||
| public: QString providerName; | |||
There was a problem hiding this comment.
include <Qstring> and <QStringList>
There was a problem hiding this comment.
Added in ImageDisplay.hh since they are needed there as well.
| @@ -95,13 +111,12 @@ void ImageDisplay::LoadConfig(const tinyxml2::XMLElement *_pluginElem) | |||
| this->PluginItem()->setProperty("showPicker", topicPicker); | |||
|
|
|||
| if (!topic.empty()) | |||
| this->OnTopic(QString::fromStdString(topic)); | |||
| { | |||
| auto qTopic = QString::fromStdString(topic); | |||
There was a problem hiding this comment.
Suggested change
| auto qTopic = QString::fromStdString(topic); | |
| auto qTopic = QString::fromStdString(topic); |
| @@ -225,6 +240,7 @@ void ImageDisplay::OnTopic(const QString _topic) | |||
| ///////////////////////////////////////////////// | |||
| void ImageDisplay::OnRefresh() | |||
| { | |||
| gzwarn << "OnRefresh\n"; | |||
| @@ -249,6 +265,7 @@ void ImageDisplay::OnRefresh() | |||
| // Select first one | |||
| if (this->dataPtr->topicList.count() > 0) | |||
| this->OnTopic(this->dataPtr->topicList.at(0)); | |||
| gzwarn << "TopicListChanged\n"; | |||
Instead of generating a random string from a UUID, this adds a new member function that gets called from the QML to register the image provider with a unique name. Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
The UUID implementation broke tests, so I've changed the implementation a little bit. Instead of generating a random string, the QML now calls |
ahcorde
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
To fix this, I've opted for generating a random string based on a UUID number.To fix this, the QML now calls a member function of ImageDisplay to register the image provider with a unique name.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.