Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegal anchor warnings (backport #2741) #2744

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2025

🦟 Bug fix

Summary

Anchors should not be used when objects are inside Layouts. Doing so causes the following warning

Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #2741 done by [Mergify](https://mergify.com).

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 26621d4)
@mergify mergify bot requested a review from mjcarroll as a code owner January 29, 2025 17:55
@mergify mergify bot mentioned this pull request Jan 29, 2025
8 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 29, 2025
@azeey azeey enabled auto-merge (rebase) January 29, 2025 18:49
@azeey azeey merged commit 0e02d36 into gz-sim8 Jan 29, 2025
10 of 11 checks passed
@azeey azeey deleted the mergify/bp/gz-sim8/pr-2741 branch January 29, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant