Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register MeshInertialCalculator when loading sim from an SDF string #2754

Open
wants to merge 1 commit into
base: gz-sim8
Choose a base branch
from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 31, 2025

🎉 New feature

Summary

MeshInertialCalculator was added in #2061. It was only set for sim loaded from SDF file. This PR turns it on for sim loaded from SDF string.

Note this PR is targeted at gz-sim8 because it looks like there are a lot of changes between gz-sim8 and gz-sim9 due to #2638. After this is merged, we should merge gz-sim8 forward to gz-sim9

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner January 31, 2025 21:31
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 31, 2025
@iche033
Copy link
Contributor Author

iche033 commented Jan 31, 2025

@azeey - just want to double check with you if there's any reason that MeshInertialCalculator was only enabled for sim loaded from an SDF file and not SDF string.

@iche033 iche033 requested a review from azeey January 31, 2025 21:39
@azeey
Copy link
Contributor

azeey commented Jan 31, 2025

It's probably an oversight. Looking at the code, it looks like there's some code duplication that led to it. I'd recommend moving the creation of sdfParserConfig out of the case statement so that the two branches can share the same sdfParserConfig object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants