Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement INCHARMAP function #1184

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Implement INCHARMAP function #1184

merged 1 commit into from
Nov 2, 2023

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Oct 28, 2023

Fixes #1175.

This does introduce a new keyword, but I didn't see it used in any assembly projects (ucity, any of pret, no mention in gbdev).

@Rangi42 Rangi42 requested a review from ISSOtm October 28, 2023 01:25
@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Oct 28, 2023
@Rangi42 Rangi42 added this to the v0.6.2 milestone Oct 28, 2023
ISSOtm
ISSOtm previously requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is good and the implementation sound, I am however concerned about the choice of keyword: it seems to imply it's testing whether its argument is a character?

I think INCHARMAP would convey the intent better, for example.

@Rangi42 Rangi42 changed the title Implement ISCHAR function Implement INCHARMAP function Nov 2, 2023
@Rangi42 Rangi42 requested a review from ISSOtm November 2, 2023 17:10
@ISSOtm ISSOtm merged commit 181512a into gbdev:master Nov 2, 2023
24 checks passed
@Rangi42 Rangi42 deleted the ischar branch November 2, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

[Feature request] Check if a charmap character is defined
2 participants
@Rangi42 @ISSOtm