Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export anonymous labels #1185

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Don't export anonymous labels #1185

merged 1 commit into from
Oct 31, 2023

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Oct 28, 2023

Fixes #1137

I do wonder if there was some reason or necessity for anonymous labels to ever be exported.

@Rangi42 Rangi42 assigned ISSOtm and unassigned ISSOtm Oct 28, 2023
@Rangi42 Rangi42 requested a review from ISSOtm October 28, 2023 03:59
@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM labels Oct 28, 2023
@Rangi42 Rangi42 added this to the v0.6.2 milestone Oct 28, 2023
@ISSOtm
Copy link
Member

ISSOtm commented Oct 31, 2023

I hate the way anon labels have to be detected, but frankly it's par for the course so lol.

@ISSOtm ISSOtm merged commit 32bc68d into gbdev:master Oct 31, 2023
24 checks passed
@Rangi42 Rangi42 deleted the no-export-anon branch November 1, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anonymous labels should not be exported with rgbasm -E
2 participants