Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an iterator template for enum sequence loops #1228

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Use an iterator template for enum sequence loops #1228

merged 1 commit into from
Nov 12, 2023

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Nov 7, 2023

As mentioned in #1176.

@Rangi42 Rangi42 added the refactoring This PR is intended to clean up code more than change functionality label Nov 7, 2023
@Rangi42 Rangi42 added this to the v0.7.0 milestone Nov 7, 2023
@Rangi42 Rangi42 requested a review from ISSOtm November 7, 2023 22:49
ISSOtm
ISSOtm reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks. Feel free to address them or ignore them and merge straight away.

include/itertools.hpp Show resolved Hide resolved
include/itertools.hpp Show resolved Hide resolved
@Rangi42 Rangi42 requested a review from ISSOtm November 7, 2023 22:55
@Rangi42 Rangi42 force-pushed the enum-seq branch 3 times, most recently from 16b0f34 to 32e6e8b Compare November 12, 2023 01:55
@ISSOtm ISSOtm merged commit e824e34 into gbdev:master Nov 12, 2023
24 checks passed
@Rangi42 Rangi42 deleted the enum-seq branch November 12, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
refactoring This PR is intended to clean up code more than change functionality
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rangi42 @ISSOtm