PR-viraj-pratapwant #4
Conversation
|
I'm unable to get the tests for this to work. Missing references to the NUnit TestAdapter, and Microsoft Test SDK, but once these are added and the tests run then Moq is throwing guard exceptions because you're attempting to mock over non-overridable members. For example, see line 29 in MailTransferServiceTests: mailContainerMock.Setup(c => c.AllowedMailType).Returns(AllowedMailType.StandardLetter); This immediately throws an exception because AllowedMailType is not virtual. |
|
I'm a little confused here. The tests do now run, so you've fixed the dependency issues, but you've solved the Moq issue by removing the mocking. And three of the tests still fail. I would assume that all tests would be passing before you made the commit. Is that true for your environment? In which case, I'm not sure why it's different on mine. And on Moq; presumably this was working for you when you made the original commit? I can't see how that was the case given the restriction on mocking non-virtual members. To be clear: did the original code that you committed work (and was tested to work) on your machine? |
|
Hi Neil, I apologize for the confusion that has arisen. I want to acknowledge the issues I've been facing with my development environment as I switch between a Mac and Windows. Initially, I was able to run the test code successfully, and that's what I intended to include in the initial commit. However, when you encountered difficulties, I attempted to switch environments, which may have contributed to the changes and issues that have occurred. I apologize for any inconvenience caused by these circumstances. |
|
Hi Viraj. If you'd like to fix the code and make another commit, I'll be happy to have a look at a final version. |
|
Good morning, Neil. I have fixed the code alongside my previous message, and all tests have been successfully executed. Could you please review it? |
No description provided.