Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some text wrapping issues in side nav and file download component #1783

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

ARADDCC002
Copy link
Member

No description provided.

@PE39806
Copy link
Contributor

PE39806 commented Jan 27, 2025

The only problem I can see is if there is a NavMenuItem with a very long title, then we may lose some displayed data e.g. here the file names for a Release are lost. If the window is made even smaller and/or if the Toolbar is collapsed then this isn't a problem.
image

@ARADDCC002
Copy link
Member Author

The only problem I can see is if there is a NavMenuItem with a very long title, then we may lose some displayed data e.g. here the file names for a Release are lost. If the window is made even smaller and/or if the Toolbar is collapsed then this isn't a problem. image

The expanded menu isn't designed to be used at the same time as the main application, it's purely for navigational purposes, so I'm happy that when it's expanded the rest of the app might not be fully usable depending on screen resolution.

@ARADDCC002 ARADDCC002 merged commit dfb4897 into main Jan 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants