Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the testing of the GafferEntityGenerator class #3098

Closed
tb06904 opened this issue Nov 16, 2023 · 0 comments · Fixed by #3099
Closed

Improve the testing of the GafferEntityGenerator class #3098

tb06904 opened this issue Nov 16, 2023 · 0 comments · Fixed by #3099
Assignees
@tb06904
Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.0

Comments

@tb06904
Copy link
Member

tb06904 commented Nov 16, 2023

Improve the testing of the GafferEntityGeneratorso that it has adequate coverage e.g. > 80%

Could also look at improving the test quality using mutation testing to check for areas of improvement.

Minor changes to the class may be permitted to improve tests.
@tb06904 tb06904 added enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module labels Nov 16, 2023
@tb06904 tb06904 added this to the v2.2.0 milestone Nov 16, 2023
@tb06904 tb06904 self-assigned this Nov 16, 2023
@tb06904 tb06904 linked a pull request Nov 16, 2023 that will close this issue
Gh-3098: Improve Testing of GafferEntityGenerator #3099
Merged
@github-actions github-actions bot mentioned this issue Nov 16, 2023
Merged
t92549 added a commit that referenced this issue Nov 20, 2023
@t92549
Merge branch 'develop' into gh-3098-improve-testing-gafferentitygener…
e7bcb57 
…ator
t92549 added a commit that referenced this issue Nov 20, 2023
@tb06904 @t92549
Gh-3098: Improve Testing of GafferEntityGenerator (#3099)
b934828 
* Improve tests and coverage

* remove redundant checks

* check for empty properties

---------

Co-authored-by: t92549 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tb06904 tb06904

Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Gh-3098: Improve Testing of GafferEntityGenerator gchq/Gaffer
1 participant
@tb06904