Gh-3098: Improve Testing of GafferEntityGenerator

[tb06904]

Improves tests for the GafferEntityGenerator coverage now > 80%

Small tweak to the main class so it checks for null values and to use easier to read lambdas.

Related issue

• Resolve Improve the testing of the GafferEntityGenerator class #3098

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8e3a97) 65.52% compared to head (e7bcb57) 65.53%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #3099      +/-   ##
=============================================
+ Coverage      65.52%   65.53%   +0.01%     
- Complexity      2657     2660       +3     
=============================================
  Files            909      909              
  Lines          29014    29008       -6     
  Branches        3238     3234       -4     
=============================================
- Hits           19012    19011       -1     
+ Misses          8557     8547      -10     
- Partials        1445     1450       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GCHQDeveloper314]

You've added null checks for the vertex properties, but this is showing as untested.

[tb06904]

You've added null checks for the vertex properties, but this is showing as untested.

I haven't added them they were in the existing logic although looking at the code a bit more is impossible to actually make a GafferPop Edge or Vertex with a property that has a null key as it is validated when its added and also the properties are technically stored in a HashMap which also fundamentally does not allow it. Therefore these checks likely can just be removed as they are adding nothing.