Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 3065 pom fix #3066

Closed
wants to merge 16 commits into from
Closed

Gh 3065 pom fix #3066

wants to merge 16 commits into from

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented Nov 7, 2023 •
edited by github-actions bot
Loading

@GCHQDev404
Validation Bug
96b24cc
@GCHQDev404
gh-3059 Updaed ApplyViewToElementsFunction to merge the Schema valida…
5d4b3e9 
…tion into view.
@GCHQDev404
gh-3059 Updated ApplyViewToElementsFunction to merge the Schema valid…
b4d5b9d 
…ation into view POST Aggregation to work after a groupBy aggregation change.
@GCHQDev404
Merge remote-tracking branch 'origin/gh-3059-federated-store-applyvie…
644c8a5 
…wtoelements-schema-validation' into gh-3059-federated-store-applyviewtoelements-schema-validation

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/ApplyViewToElementsFunction.java
@GCHQDev404
gh-3059 Updated ApplyViewToElementsFunction to merge the Schema valid…
a3f2597 
…ation should only be done for the TemporaryStore of type MapStore
@GCHQDev404
gh-3059 Nullpointers and Test cache clearing
11f406e
@GCHQDev404
gh-3059 test fixes
bffc015
@GCHQDev404
checkstyle
eb03f10
@GCHQDev404
gh-3059 map improvements.
33a5721
@GCHQDev404
gh-3059 stream improvements.
8e07f18
@GCHQDev404
gh-3059 rename.
abd4950
@GCHQDev404
gh-3059 Graph or GraphSerialisable.
7906716
@GCHQDev404
gh-3059 test move.
cd31331
@GCHQDev404
gh-3059 tidy up
48942f7
@GCHQDev404
gh-3059 logic typo
5dba0fe
@GCHQDev404
Merge branch 'develop' into gh-3065-intelij-pom-fix
b05c62a
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ecc9f44) 65.26% compared to head (b05c62a) 65.28%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #3066      +/-   ##
=============================================
+ Coverage      65.26%   65.28%   +0.01%     
+ Complexity      2639     2637       -2     
=============================================
  Files            907      907              
  Lines          28963    28993      +30     
  Branches        3249     3254       +5     
=============================================
+ Hits           18904    18927      +23     
- Misses          8600     8603       +3     
- Partials        1459     1463       +4
Files Coverage Δ
...gov/gchq/gaffer/federatedstore/FederatedStore.java 87.70% <100.00%> (ø)
...gaffer/federatedstore/util/FederatedStoreUtil.java 83.75% <ø> (ø)
.../federatedstore/util/FederatedElementFunction.java 67.08% <88.88%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GCHQDev404 GCHQDev404 changed the title Gh 3065 intelij pom fix Gh 3065 pom fix Nov 7, 2023
@GCHQDev404 GCHQDev404 closed this Nov 7, 2023
@GCHQDev404 GCHQDev404 deleted the gh-3065-intelij-pom-fix branch November 7, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java version keeps changing to 1.5
1 participant
@GCHQDev404