Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-3059 FederatedElementFunction merge graph only supports MapStore. #3068

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented Nov 7, 2023

…dation' into gh-3059-other-temp-merge-graphs

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/FederatedStoreUtil.java
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9721d56) 65.28% compared to head (d9f1c0c) 65.31%.

Additional details and impacted files
@@                                         Coverage Diff                                         @@
##             gh-3059-federated-store-applyviewtoelements-schema-validation    #3068      +/-   ##
===================================================================================================
+ Coverage                                                            65.28%   65.31%   +0.03%     
- Complexity                                                            2637     2639       +2     
===================================================================================================
  Files                                                                  907      908       +1     
  Lines                                                                28993    29006      +13     
  Branches                                                              3254     3256       +2     
===================================================================================================
+ Hits                                                                 18927    18945      +18     
+ Misses                                                                8603     8599       -4     
+ Partials                                                              1463     1462       -1     
Files Coverage Δ
...ration/handler/impl/FederatedOperationHandler.java 95.74% <100.00%> (+0.18%) ⬆️
...ffer/federatedstore/util/MergeElementFunction.java 67.08% <ø> (ø)
...store/util/MergeElementFunctionWithGivenStore.java 100.00% <100.00%> (ø)
...gaffer/federatedstore/util/FederatedStoreUtil.java 84.93% <83.33%> (+1.18%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n3101 n3101 changed the title gh-3059 FederatedElementFunction merge graph is only supports MapStor… gh-3059 FederatedElementFunction merge graph only supports MapStor… Nov 8, 2023
@n3101 n3101 changed the title gh-3059 FederatedElementFunction merge graph only supports MapStor… gh-3059 FederatedElementFunction merge graph only supports MapStore. Nov 8, 2023
@GCHQDev404 GCHQDev404 closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant