Gh-3091: Improve testing of GafferPop NamedOperationService #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCHQDeveloper314
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3102 +/- ##
=============================================
+ Coverage 65.56% 65.71% +0.14%
+ Complexity 2667 2514 -153
=============================================
Files 909 909
Lines 29008 29008
Branches 3234 3234
=============================================
+ Hits 19020 19062 +42
+ Misses 8541 8499 -42
Partials 1447 1447 ☔ View full report in Codecov by Sentry. |
t92549
reviewed
Nov 20, 2023
...pop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationServiceIT.java
Outdated
Show resolved
Hide resolved
...pop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationServiceIT.java
Outdated
Show resolved
Hide resolved
...p/src/test/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationServiceTest.java
Outdated
Show resolved
Hide resolved
t92549
previously approved these changes
Nov 21, 2023
tb06904
reviewed
Nov 21, 2023
...est/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationServiceFactoryTest.java
Outdated
Show resolved
Hide resolved
…OperationService
t92549
approved these changes
Nov 21, 2023
tb06904
approved these changes
Nov 21, 2023
GCHQDeveloper314
deleted the
gh-3090-improve-testing-of-GafferPopNamedOperationService
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a fix for missing Generics in the class itself
Related issue