Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3108: Improve testing for GafferPopVertexProperty #3110

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Nov 22, 2023

Improves the testing on GafferPopVertexProperty class to above > 80% coverage.

Slight tweak to reduce mock duplication in the existing test class too.

Related issue

@tb06904 tb06904 linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0dcee3) 65.74% compared to head (b56f27f) 65.79%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3110      +/-   ##
=============================================
+ Coverage      65.74%   65.79%   +0.05%     
- Complexity      2512     2514       +2     
=============================================
  Files            909      909              
  Lines          29008    29004       -4     
  Branches        3237     3235       -2     
=============================================
+ Hits           19070    19083      +13     
+ Misses          8488     8475      -13     
+ Partials        1450     1446       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t92549
Copy link
Contributor

t92549 commented Nov 23, 2023

There is now only this that remains with no coverage:

if (propertyKeys.length == 1) {
final Property<U> property = properties.get(propertyKeys[0]);
return null == property ? Collections.emptyIterator() : IteratorUtils.of(property);
}

If I am honest I don't really understand this. It might be good to either test it or remove it?

@t92549 t92549 merged commit 8499f33 into develop Nov 27, 2023
24 checks passed
@t92549 t92549 deleted the gh-3108-improve-testing-for-gafferpopvertexproperty branch November 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve testing for GafferPopVertexProperty
3 participants