-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3108: Improve testing for GafferPopVertexProperty #3110
Gh-3108: Improve testing for GafferPopVertexProperty #3110
Conversation
…sting-for-gafferpopvertexproperty
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3110 +/- ##
=============================================
+ Coverage 65.74% 65.79% +0.05%
- Complexity 2512 2514 +2
=============================================
Files 909 909
Lines 29008 29004 -4
Branches 3237 3235 -2
=============================================
+ Hits 19070 19083 +13
+ Misses 8488 8475 -13
+ Partials 1450 1446 -4 ☔ View full report in Codecov by Sentry. |
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopVertexTest.java
Show resolved
Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopVertexTest.java
Outdated
Show resolved
Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopVertexTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: GCHQDeveloper314 <[email protected]>
There is now only this that remains with no coverage: Gaffer/library/tinkerpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopVertexProperty.java Lines 113 to 116 in 1ef3621
If I am honest I don't really understand this. It might be good to either test it or remove it? |
Improves the testing on
GafferPopVertexProperty
class to above > 80% coverage.Slight tweak to reduce mock duplication in the existing test class too.
Related issue