Gh-3106: Refactor GafferPopNamedOperationService #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tb06904
reviewed
Nov 22, 2023
...erpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationService.java
Show resolved
Hide resolved
...erpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationService.java
Outdated
Show resolved
Hide resolved
...erpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationService.java
Show resolved
Hide resolved
...erpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationService.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3111 +/- ##
=============================================
- Coverage 66.05% 66.04% -0.02%
+ Complexity 2514 2512 -2
=============================================
Files 909 909
Lines 29004 29004
Branches 3235 3233 -2
=============================================
- Hits 19160 19156 -4
- Misses 8408 8410 +2
- Partials 1436 1438 +2 ☔ View full report in Codecov by Sentry. |
t92549
reviewed
Nov 27, 2023
...erpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationService.java
Show resolved
Hide resolved
tb06904
approved these changes
Dec 1, 2023
t92549
approved these changes
Dec 1, 2023
...erpop/src/main/java/uk/gov/gchq/gaffer/tinkerpop/service/GafferPopNamedOperationService.java
Show resolved
Hide resolved
GCHQDeveloper314
deleted the
gh-3106-refactor-and-improve-GafferPopNamedOperationService
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Generics handing is not ideal. This is due to the implementation of generators, how this class is used and TinkerPop itself (rawtype
Map).Related issue