Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-3149: @JsonCreator constructor needs to be tested #3176

Closed
wants to merge 16 commits into from
Closed

Gh-3149: @JsonCreator constructor needs to be tested #3176

wants to merge 16 commits into from

Conversation

GCHQDev404
Copy link
Contributor

@GCHQDev404 GCHQDev404 commented Mar 20, 2024 •
edited by github-actions bot
Loading

@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (c0b950f) to head (8b28d97).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #3176   +/-   ##
==========================================
  Coverage      66.78%   66.78%           
  Complexity      2558     2558           
==========================================
  Files            910      910           
  Lines          29217    29217           
  Branches        3256     3256           
==========================================
  Hits           19512    19512           
  Misses          8261     8261           
  Partials        1444     1444

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from gh-3149-namedoperationresolver-depth-limit to develop March 21, 2024 11:23
@GCHQDev404
Merge remote-tracking branch 'origin/develop' into gh-3149-namedopera…
d97fc68 
…tionresolver-depth-limit-test-change

# Conflicts:
#	core/graph/src/main/java/uk/gov/gchq/gaffer/graph/hook/NamedOperationResolver.java
#	core/graph/src/test/java/uk/gov/gchq/gaffer/graph/hook/NamedOperationResolverTest.java
@GCHQDeveloper314 GCHQDeveloper314 changed the title gh-3149 the @JsonCreator constructor needs to be tested. Gh-3149: @JsonCreator constructor needs to be tested May 2, 2024
@GCHQDeveloper314 GCHQDeveloper314 mentioned this pull request May 7, 2024
Open
@GCHQDeveloper314
Copy link
Member

GCHQDeveloper314 commented May 7, 2024 •
edited
Loading

This should be recreated as part of #3207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use depth limit rather than timeout on NamedOperationResolver
4 participants
@GCHQDev404 @GCHQDeveloper314 @rj77259 @tb06904