-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3322: Cache updates for federated POC #3323
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3323 +/- ##
=============================================
+ Coverage 67.90% 67.95% +0.04%
- Complexity 2596 2597 +1
=============================================
Files 953 955 +2
Lines 30498 30530 +32
Branches 3363 3369 +6
=============================================
+ Hits 20710 20746 +36
+ Misses 8312 8306 -6
- Partials 1476 1478 +2 ☔ View full report in Codecov by Sentry. |
.../main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/EitherOperationHandler.java
Show resolved
Hide resolved
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Outdated
Show resolved
Hide resolved
.../main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/EitherOperationHandler.java
Show resolved
Hide resolved
...c/main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/SeparateOutputHandler.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Few updates to how the federated store uses the cache. This allows users to specify a custom cache name for the graph cache which would enable sharing of graphs between federated stores.
This also addresses the handling of operations that technically could be handled by a federated store or by a sub graph. The overall logic has been simplified so that if an operation has graph IDs specified (or excluded) it will be assumed the operation should be run on those sub graphs.
This change has the added benefit of meaning mixing operations in the same chain e.g. for sub graphs or not, is handled seamlessly.
Related issue