Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

166 HQDM Extensions Mechanism #167

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Conversation

twalmsley
Copy link
Collaborator

See HQDM Model Extension Example for how to write an extension module.

(We could perhaps copy the example into the MC repo or create a better example.)

@twalmsley twalmsley self-assigned this Jan 19, 2024
@twalmsley twalmsley linked an issue Jan 19, 2024 that may be closed by this pull request
@GCHQDeveloper42
Copy link
Contributor

This functionality could do with unit testing, but seen as we don't have a test suite for HqdmObjectFactory yet, that may be asking too much of this PR.

@twalmsley
Copy link
Collaborator Author

  • I added a module containing the example extension (it's a separate module so that it gets built to a JAR for use by the examples module).
  • I wasn't able to get a JUnit test working in the examples module so I added it to src/main/java instead as a main program which runs successfully. There are instructions about how to run it in the class javadoc.

Perhaps at some point we can create a proper unit test if that's possible, but right now I think this might have to suffice.

@GCHQDeveloper42 GCHQDeveloper42 merged commit 9977e98 into main Jan 25, 2024
3 checks passed
@GCHQDeveloper42 GCHQDeveloper42 deleted the 166-hqdm-extensions-mechanism branch January 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HQDM Extensions Mechanism
2 participants