Something must have change in CircuitPython #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your code was not working for me on CircuitPython 5.3+ (maybe before). Need to import usb_hid to later use that to create the keyboard object. Then, I could not find send_code function anymore, so I did this in two step, set the code, then send. This is working for me, but I don't know exactly what I am doing. I would advise to test yourself before accepting this PR. Regards.
There was another usage of keyboard.hid_keyboard.send_report that needed to be fixed.
|
There is another change that might reduce the verbosity of this code. |
|
Tested this code in CPy 7.2. Worked. Please consider merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your code was not working for me on CircuitPython 5.3+ (maybe before).
Need to import usb_hid to later use that to create the keyboard object.
Then, I could not find send_code function anymore, so I did this in two step, set the code, then send.
This is working for me, but I don't know exactly what I am doing.
I would advise to test yourself before accepting this PR.
Regards.