refactor(ethexe): simplify program creation and message sending in tests #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st cases - Updated test cases to remove unnecessary payload and value parameters in `create_program` calls. - Replaced direct assertions on initialization message properties with assertions on reply messages.
breathx
requested changes
Feb 7, 2025
| @@ -1202,18 +1267,10 @@ mod utils { | |||
| } | |||
|
|
|||
| // TODO (breathx): split it into different functions WITHIN THE PR. | |||
| payload: &[u8], | ||
| value: u128, | ||
| ) -> Result<WaitForProgramCreation> { | ||
| pub async fn create_program(&self, code_id: CodeId) -> Result<WaitForProgramCreation> { |
There was a problem hiding this comment.
rm EXECUTABLE BALANCE constant in favor of func argument / another func that will create program and topup balance
There was a problem hiding this comment.
so in case of absence of exec balance there's no need in approve
breathx
reviewed
Feb 7, 2025
| assert_eq!( | ||
| res.reply_code, | ||
| ReplyCode::Success(SuccessReplyReason::Manual) | ||
| ); | ||
| assert_eq!(res.reply_payload, b"PONG"); |
There was a problem hiding this comment.
overall refactor would be good as well
Suggested change
| assert_eq!(res.reply_payload, b"PONG"); | |
| assert_eq!(reply.payload, b"PONG"); // etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_programcalls.