[net]build(nuget): make published Sails.Net NuGet healthier (#737)

net/.editorconfig

@@ -502,6 +502,12 @@ csharp_style_unused_value_assignment_preference = discard_variable:none
 dotnet_diagnostic.IDE0059.severity = none
 dotnet_diagnostic.CA1416.severity = warning
 
+# Disable some checks for generated code
+[**/Substrate.Gear.Api/Api/**/*.cs]
+dotnet_diagnostic.CS1570.severity = none
+dotnet_diagnostic.CS1573.severity = none
+dotnet_diagnostic.CS1587.severity = none
+
 # Verify settings
 [*.{received,verified}.{json,txt,xml,cs}]
 charset = "utf-8-bom"

net/src/Sails.ClientGenerator/Sails.ClientGenerator.csproj

@@ -10,9 +10,12 @@
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Description>Code generator for clients to communictae with Sails programs</Description>
+    <Deterministic>true</Deterministic>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <PackageLicenseExpression>MIT OR Apache-2.0</PackageLicenseExpression>
-    <PackageTags>Sails, Vara, Gear, Substrate</PackageTags>
+    <PackageTags>Sails;Vara;Gear;Substrate</PackageTags>
     <MinVerTagPrefix>net/v</MinVerTagPrefix>
   </PropertyGroup>
 

net/src/Sails.Net/Sails.Net.csproj

@@ -3,9 +3,13 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <Description>Low-level abstractions for communicating with Sails programs</Description>
+    <Deterministic>true</Deterministic>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <PackageLicenseExpression>MIT OR Apache-2.0</PackageLicenseExpression>
-    <PackageTags>Sails, Vara, Gear, Substrate</PackageTags>
+    <PackageTags>Sails;Vara;Gear;Substrate</PackageTags>
     <MinVerTagPrefix>net/v</MinVerTagPrefix>
   </PropertyGroup>
 

net/src/Substrate.Gear.Client/NetApi/Model/Types/Base/BaseDictionary.cs

@@ -12,13 +12,13 @@ public class BaseDictionary<TKey, TValue> : IType
         where TValue : IType, new()
 {
     /// <summary>
-    /// Explicit conversion from Dictionary<TKey, TValue> to BaseDictionary
+    /// Explicit conversion from <see cref="Dictionary{TKey, TValue}"></see> to BaseDictionary
     /// </summary>
     /// <param name="p"></param>
     public static explicit operator BaseDictionary<TKey, TValue>(Dictionary<TKey, TValue> p) => new(p);
 
     /// <summary>
-    /// Implicit conversion from BaseDictionary to Dictionary<TKey, TValue>
+    /// Implicit conversion from BaseDictionary to <see cref="Dictionary{TKey, TValue}"></see>
     /// </summary>
     /// <param name="p"></param>
     public static implicit operator Dictionary<TKey, TValue>(BaseDictionary<TKey, TValue> p) => p.Value;
@@ -68,7 +68,7 @@ public byte[] Encode()
             result.AddRange(kv.Key.Encode());
             result.AddRange(kv.Value.Encode());
         }
-        return result.ToArray();
+        return [.. result];
     }
 
     /// <summary>

net/src/Substrate.Gear.Client/ReplyInfo.cs

@@ -10,10 +10,10 @@ public sealed record ReplyInfo
     public required byte[] EncodedPayload { get; init; }
     /// <summary>
     /// Value sent with the reply.
-    /// /// </summary>
+    /// </summary>
     public required ValueUnit Value { get; init; }
     /// <summary>
     /// Reply code of the reply.
-    /// <summary>
+    /// </summary>
     public required EnumReplyCode Code { get; init; }
 }