Bitrate fix #7
Open
Bitrate fix #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small fix fixes the incorrect video bitrate. By default the Majestic has 1200 Bytes NAL Size stream. This means every pkt received by Radxa is 1200 Bytes, NOT 1024 Bytes. So for example on MCS3 if we have a video stream of 2700 pkt/s the video bitrate is: (2700*1200*8)/1024/1024=25Mbps To confirm the video stream run wfb-cli gs on the Radxa to monitor the packets received.
gehee
reviewed
May 17, 2024
| @@ -108,9 +108,9 @@ void modeset_paint_buffer(struct modeset_buf *buf) { | |||
| } | |||
| avg_bw = avg_bw / avg_cnt; | |||
| if (avg_bw < 1000) { | |||
| sprintf(msg, "%.2f Kbps", avg_bw / 125 ); | |||
| sprintf(msg, "%.2f Kbps", avg_bw / 75 ); | |||
There was a problem hiding this comment.
That's incorrect, the average bandwidth is bytes/second so 125 or 125000 is the right value.
Where is 75 is coming from?
avg_bw is populated from frame->size() which is an array of uin8_t (= a byte).
https://github.com/gehee/FPVue_rk/blob/main/main.cpp#L373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small fix fixes the incorrect video bitrate.
By default the Majestic has 1200 Bytes NAL Size stream. This means every pkt received by Radxa is 1200 Bytes, NOT 1024 Bytes. So for example on MCS3 if we have a video stream of 2700 pkt/s the video bitrate is: (270012008)/1024/1024=25Mbps
To confirm the video stream run wfb-cli gs on the Radxa to monitor the packets received.