Type error display #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type errors are improved by doing the following: 1. Normalize types in them as far as possible, so it's not just a TyF around METAs in the error message 2. When the unification error occurs in a nested call to unify, call that out but also save the original types. Show the inner fail in a "Specifically" block as GHC does.
david-christiansen
force-pushed
the
type-error-display
branch
2 times, most recently
from
8130c3a to
f8fb67b
Compare
This makes the code easier to understand and improves GHC warnings.
david-christiansen
force-pushed
the
type-error-display
branch
from
f8fb67b to
cf60a26
Compare
langston-barrett
approved these changes
May 6, 2020
|
Yeah, that'd be nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part of #49 that I think is basically non-controversial and involves no major changes to anything. Might as well get it merged once #47 is in.
This does the following, on top of #47: