Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orcid to db-xrefs.yaml #1956

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Add orcid to db-xrefs.yaml #1956

merged 1 commit into from
Feb 12, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Feb 12, 2023

This PR adds ORCID to the GO registry. See also https://bioregistry.io/registry/orcid for more detailed information about ORCID.

This should add additional context to geneontology/go-ontology#24694 and other efforts based on GO that want to make their contributor provenance more informative, i.e., by using standard ORCID identifiers instead of locally-defined mnemonics

This PR adds ORCID to the GO registry. See also https://bioregistry.io/registry/orcid for more detailed information about ORCID.
@kltm
Copy link
Member

kltm commented Feb 12, 2023

I'm not sure about what the fix is in geneontology/go-ontology#24694 (tagging @cmungall ), but this looks fine on this end and makes sense to have in the db-xrefs.yaml metadata file as linking (not id) information.

@kltm
Copy link
Member

kltm commented Feb 12, 2023

Approved to run (looks like we're protected now).

@kltm kltm merged commit 793e926 into geneontology:master Feb 12, 2023
@cthoyt cthoyt deleted the patch-1 branch February 12, 2023 22:28
@cthoyt
Copy link
Contributor Author

cthoyt commented Feb 12, 2023

Thanks @kltm! Do you know if it's possible to easily rebuild http://snapshot.geneontology.org/metadata/db-xrefs.legacy to reflect this change?

@kltm
Copy link
Member

kltm commented Feb 12, 2023

@cthoyt That rebuilds when the snapshot cycle completes. It typically starts every two days, but we've paused it temporarily while a release moves through the pipeline. It will likely be updated sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants