mail-client/alot: Add version bump 0.9.1 #16680

GuillaumeSeren · 2020-07-12T17:07:27Z

No description provided.

gentoo-bot · 2020-07-12T17:08:16Z

Pull Request assignment

Submitter: @GuillaumeSeren
Areas affected: ebuilds
Packages affected: dev-python/urwidtrees, mail-client/alot

dev-python/urwidtrees: @gentoo/proxy-maint (maintainer needed)
mail-client/alot: @GuillaumeSeren, @gentoo/proxy-maint

Linked bugs

Bugs linked: 732360, 732362

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

DarthGandalf · 2020-07-12T17:10:01Z

dev-python/urwidtrees/urwidtrees-1.0.3.ebuild

+# Copyright 1999-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7


add an empty line below

DarthGandalf · 2020-07-12T17:16:06Z

dev-python/urwidtrees/urwidtrees-1.0.3.ebuild

+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7
+PYTHON_COMPAT=( python{3_6,3_7,3_8} )


you could put 3_ outside of {}

DarthGandalf · 2020-07-12T17:16:44Z

mail-client/alot/alot-0.9.1.ebuild

@@ -18,17 +19,16 @@ IUSE="doc test"
 RESTRICT="!test? ( test )"

 RDEPEND="
-	>=app-crypt/gpgme-1.9.0[python,${PYTHON_USEDEP}]
-	>=dev-python/configobj-4.7.0[${PYTHON_USEDEP}]
+	app-crypt/gpgme[python,${PYTHON_USEDEP}]


why did you remove >=?

Just because the minimal available version in portage is sufficient (1.13.0).

gentoo-repo-qa-bot · 2020-07-12T17:26:32Z

Pull request CI report

Report generated at: 2020-07-12 17:26 UTC
Newest commit scanned: a62a60a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/87d95bf5b2/output.html

janko-j1 · 2020-07-13T10:15:53Z

dev-python/urwidtrees/urwidtrees-1.0.3.ebuild

+LICENSE="GPL-3"
+SLOT="0"
+KEYWORDS="~amd64 ~x86"
+IUSE="doc"


You should probably use distutils_enable_sphinx, which appends the doc keyword to IUSE for you: you can drop this line.

janko-j1 · 2020-07-13T10:16:15Z

dev-python/urwidtrees/urwidtrees-1.0.3.ebuild

+src_compile() {
+	distutils-r1_src_compile
+
+	use doc && emake -C docs html
+}
+
+src_install() {
+	distutils-r1_src_install
+
+	if use doc; then
+		dodoc -r docs/build/html/.
+	fi
+}


Those lines can be replaced by a single distutils_enable_sphinx call

janko-j1 · 2020-07-13T10:18:45Z

mail-client/alot/alot-0.9.1.ebuild

 	>=dev-python/twisted-18.4[${PYTHON_USEDEP}]
 	net-mail/mailbase
-	>=net-mail/notmuch-0.27[crypt,python]
+	net-mail/notmuch[crypt,python]
 	"
 DEPEND="


This should be BDEPEND. It can be called after distutils_enable_tests, which automatically appends test? ( ${RDEPEND} ) to it.

janko-j1 · 2020-07-13T10:18:46Z

mail-client/alot/alot-0.9.1.ebuild

 	"
 DEPEND="
-	dev-python/setuptools[${PYTHON_USEDEP}]
 	doc? ( dev-python/sphinx[${PYTHON_USEDEP}] )


Drop this and use distutils_enable_sphinx

As discussed on irc this helper does not work when building multiple (here man page),
sphinx target.

I think you should put this as a comment in the ebuild so that one knows why distutils_enable_sphinx is not used

janko-j1 · 2020-07-13T10:19:25Z

mail-client/alot/alot-0.9.1.ebuild

 	"
 DEPEND="
-	dev-python/setuptools[${PYTHON_USEDEP}]
 	doc? ( dev-python/sphinx[${PYTHON_USEDEP}] )
 	test? (


append mock to BDEPEND after calling distutils_enable_tests

I did not get it at first now it is ok, thank you.

janko-j1 · 2020-07-13T10:20:08Z

mail-client/alot/alot-0.9.1.ebuild

+python_compile_all() {
+	emake -C docs man
+	use doc && emake -C docs html
 }

 python_install_all() {
+	use doc && local HTML_DOCS=( docs/build/html/. )
+	doman docs/build/man/*
 	distutils-r1_python_install_all

 	insinto /usr/share/alot


These lines can be replaced by a call to distutils_enable_sphinx

Unfortunately no.

janko-j1 · 2020-07-13T10:21:55Z

mail-client/alot/alot-0.9.1.ebuild

@@ -3,7 +3,8 @@

 EAPI=7

-PYTHON_COMPAT=( python3_{6,7} )
+DISTUTILS_USE_SETUPTOOLS=rdepend
+PYTHON_COMPAT=( python3_{6,7,8} )


Tests fail with py3.8 because notmuch does not have py3.8 yet. This is why the RESTRICT below?

Nevermind: #16668 will add py3.8 to notmuch

gentoo-repo-qa-bot · 2020-07-19T13:11:47Z

Pull request CI report

Report generated at: 2020-07-19 13:11 UTC
Newest commit scanned: 33e3f21
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6aef654759/output.html

gentoo-repo-qa-bot · 2020-07-24T21:51:19Z

Pull request CI report

Report generated at: 2020-07-24 21:51 UTC
Newest commit scanned: f2f5c53
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/18b6318c4a/output.html

juippis · 2020-08-05T12:37:36Z

mail-client/alot/alot-0.9.1.ebuild

+BDEPEND+=" test? ( dev-python/mock[${PYTHON_USEDEP}] ) "
+


tests.widgets.test_globals (unittest.loader._FailedTest) ... ERROR ====================================================================== ERROR: alot.buffers (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: alot.buffers Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 462, in _find_test_path package = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/__init__.py", line 7, in <module> from .envelope import EnvelopeBuffer File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/envelope.py", line 9, in <module> from ..widgets.globals import HeadersList File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/widgets/globals.py", line 14, in <module> from ..db.attachment import Attachment File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: alot.db (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: alot.db Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 462, in _find_test_path package = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.commands.test_envelope (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.commands.test_envelope Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/commands/test_envelope.py", line 26, in <module> from alot.commands import envelope File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/envelope.py", line 20, in <module> from . import globals File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/globals.py", line 24, in <module> from .. import buffers File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/__init__.py", line 7, in <module> from .envelope import EnvelopeBuffer File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/envelope.py", line 9, in <module> from ..widgets.globals import HeadersList File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/widgets/globals.py", line 14, in <module> from ..db.attachment import Attachment File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.commands.test_global (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.commands.test_global Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/commands/test_global.py", line 24, in <module> from alot.commands import globals as g_commands File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/globals.py", line 24, in <module> from .. import buffers File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/__init__.py", line 7, in <module> from .envelope import EnvelopeBuffer File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/envelope.py", line 9, in <module> from ..widgets.globals import HeadersList File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/widgets/globals.py", line 14, in <module> from ..db.attachment import Attachment File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.commands.test_init (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.commands.test_init Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/commands/test_init.py", line 10, in <module> from alot.commands import thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/thread.py", line 20, in <module> from .globals import ExternalCommand File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/globals.py", line 24, in <module> from .. import buffers File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/__init__.py", line 7, in <module> from .envelope import EnvelopeBuffer File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/envelope.py", line 9, in <module> from ..widgets.globals import HeadersList File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/widgets/globals.py", line 14, in <module> from ..db.attachment import Attachment File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.commands.test_thread (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.commands.test_thread Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/commands/test_thread.py", line 11, in <module> from alot.commands import thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/thread.py", line 20, in <module> from .globals import ExternalCommand File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/commands/globals.py", line 24, in <module> from .. import buffers File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/__init__.py", line 7, in <module> from .envelope import EnvelopeBuffer File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/buffers/envelope.py", line 9, in <module> from ..widgets.globals import HeadersList File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/widgets/globals.py", line 14, in <module> from ..db.attachment import Attachment File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.db.test_envelope (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.db.test_envelope Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/db/test_envelope.py", line 25, in <module> from alot.db import envelope File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.db.test_manager (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.db.test_manager Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/db/test_manager.py", line 12, in <module> from alot.db.manager import DBManager File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.db.test_message (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.db.test_message Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/db/test_message.py", line 21, in <module> from alot.db import message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.db.test_thread (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.db.test_thread Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/db/test_thread.py", line 22, in <module> from alot.db import thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.db.test_utils (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.db.test_utils Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/db/test_utils.py", line 26, in <module> from alot.db import utils File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.test_completion (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.test_completion Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/test_completion.py", line 10, in <module> from alot.completion.abooks import AbooksCompleter File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/completion/abooks.py", line 7, in <module> from ..db.utils import formataddr File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ====================================================================== ERROR: tests.widgets.test_globals (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: tests.widgets.test_globals Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 428, in _find_test_path module = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/tests/widgets/test_globals.py", line 22, in <module> from alot.widgets import globals as globals_ File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/widgets/globals.py", line 14, in <module> from ..db.attachment import Attachment File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/__init__.py", line 4, in <module> from .thread import Thread File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/thread.py", line 6, in <module> from .message import Message File "/var/tmp/portage/mail-client/alot-0.9.1/work/alot-0.9.1/alot/db/message.py", line 10, in <module> from notmuch import NullPointerError ModuleNotFoundError: No module named 'notmuch' ---------------------------------------------------------------------- Ran 190 tests in 0.631s

So you'll have to add it here. Most likely to RDEPEND too.

juippis · 2020-08-07T08:01:42Z

mail-client/alot/alot-0.9.1.ebuild

+	dev-python/urwidtrees[${PYTHON_USEDEP}]
+	>=dev-python/twisted-18.4[${PYTHON_USEDEP}]
+	net-mail/mailbase
+	net-mail/notmuch[crypt,python]


I still think you'll need to add PYTHON_USEDEP here, the test phase clearly implies that. However with notmuch-30 I'm not sure how it affects the runtime, you probably have a better idea? How is notmuch used by alot? It should be broken with 30 currently. Maybe the version can be restricted for now, or we wait until notmuch-30 has been fixed?

I still think you'll need to add PYTHON_USEDEP here, the test phase clearly implies that. However with notmuch-30 I'm not sure how it affects the runtime, you probably have a better idea?

I am not really sure, what I can say alot use the python binding provided by notmuch,
I used to think that when notmuch is installed it is build with all python version, maybe I am wrong.

Maybe the version can be restricted for now, or we wait until notmuch-30 has been fixed?
Yes I contacted upstream (pazz/alot#1539) it seems,
a PR is already going on to port to 'notmuch2' module (pazz/alot#1511).

So with all that, I think I probably fix to '<=net-mail/notmuch-0.30[crypt,python,${PYTHON_USEDEP}]',
until everything is fixed.

gentoo-repo-qa-bot · 2020-08-07T10:19:53Z

Pull request CI report

Report generated at: 2020-08-07 10:19 UTC
Newest commit scanned: bee4e2b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4c9d002b3d/output.html

gentoo-repo-qa-bot · 2020-08-07T10:44:58Z

Pull request CI report

Report generated at: 2020-08-07 10:44 UTC
Newest commit scanned: 891a691
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/15d2eb3e51/output.html

gentoo-repo-qa-bot · 2020-08-07T11:04:53Z

Pull request CI report

Report generated at: 2020-08-07 11:04 UTC
Newest commit scanned: 09f891e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/48f38904bb/output.html

Closes: https://bugs.gentoo.org/732360 Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

GuillaumeSeren · 2020-08-08T17:15:55Z

Hey,
I have fixed my chroot test setup, and I detected one new issue (urwid).

I tested it against a stage3 image, and it works building with tests and doc enabled.

gentoo-repo-qa-bot · 2020-08-08T17:39:51Z

Pull request CI report

Report generated at: 2020-08-08 17:39 UTC
Newest commit scanned: 41c8b7e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5c312503d8/output.html

janko-j1 · 2020-08-08T17:47:41Z

Hey,
I have fixed my chroot test setup, and I detected one new issue (urwid).

I tested it against a stage3 image, and it works building with tests and doc enabled.

Did you try alot without doc?-)

GuillaumeSeren · 2020-08-08T18:33:26Z

Did you try alot without doc?-)

I tested with doc only without test, but I am testing only test right now.

Closes: https://bugs.gentoo.org/732362 Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

Closes: https://bugs.gentoo.org/736410 Package-Manager: Portage-2.3.99, Repoman-2.3.2 Signed-off-by: Guillaume Seren <[email protected]>

Closes: https://bugs.gentoo.org/736412 Package-Manager: Portage-2.3.99, Repoman-2.3.2 Signed-off-by: Guillaume Seren <[email protected]>

GuillaumeSeren · 2020-08-08T20:16:27Z

You were right @janko-j1
I fixed the sphinx dep into a BDEPEND.

gentoo-repo-qa-bot · 2020-08-08T20:29:57Z

Pull request CI report

Report generated at: 2020-08-08 20:29 UTC
Newest commit scanned: 7ebb35f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ab81ae420f/output.html

juippis

I had to drop your urwid commits, but this is merged otherwise.

They were a bit messy and incomplete. And building urwid with [doc] doesn't work, although it doesn't work for current tree version either, could you look to fix it? Please make a new PR for urwid if you absolutely need it, but to me looks like alot can work with 2.1.

juippis · 2020-08-09T07:09:49Z

dev-python/urwid/urwid-2.1.0.ebuild

@@ -17,6 +17,10 @@ SLOT="0"
 KEYWORDS="amd64 ~arm ~arm64 ~ia64 ~mips ppc ppc64 ~sparc x86 ~amd64-linux ~x86-linux"
 IUSE="examples"

+PATCHES=(
+	"${FILESDIR}/2.1-Ignore-resetting-to-invalid-locale-Closes-377.patch"


Don't touch the stable ebuild here at all, I'm not comfortable with it.

Ok I am creating a new urwid-2.1.0-r1 with the fix in it

juippis · 2020-08-09T07:10:16Z

dev-python/urwid/urwid-2.1.1.ebuild

+IUSE="examples"
+
+PATCHES=(
+	"${FILESDIR}/2.1-Ignore-resetting-to-invalid-locale-Closes-377.patch"


Rename the patch file better, like urwid-2.1.1-ignore-resetting-to-invalid-locale.patch.

juippis · 2020-08-09T07:10:29Z

dev-python/urwid/urwid-2.1.1.ebuild

+inherit distutils-r1
+
+DESCRIPTION="Curses-based user interface library for Python"
+HOMEPAGE="http://urwid.org/ https://pypi.org/project/urwid/"


Please also add the Github page here, they seem to track issues there.

juippis · 2020-08-09T07:10:37Z

dev-python/urwid/urwid-2.1.1.ebuild

+
+LICENSE="LGPL-2.1"
+SLOT="0"
+KEYWORDS="amd64 ~arm ~arm64 ~ia64 ~mips ppc ppc64 ~sparc x86 ~amd64-linux ~x86-linux"


Don't commit straight to stable.

GuillaumeSeren · 2020-08-09T12:17:09Z

And building urwid with [doc] doesn't work, although it doesn't work for current tree version either, could you look to fix it?

I did open a issue on that on gentoo and reported upstream.
https://bugs.gentoo.org/736410

Please make a new PR for urwid if you absolutely need it, but to me looks like alot can work with 2.1.

It also break alot on master now
#17059

GuillaumeSeren · 2020-08-26T13:30:34Z

Thank you @juippis for the feedback and merge !

gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 12, 2020

DarthGandalf reviewed Jul 12, 2020

View reviewed changes

janko-j1 reviewed Jul 13, 2020

View reviewed changes

GuillaumeSeren force-pushed the mail-client/alot-add-version-bump-0.9.1 branch from a62a60a to 33e3f21 Compare July 19, 2020 12:48

GuillaumeSeren force-pushed the mail-client/alot-add-version-bump-0.9.1 branch from 33e3f21 to f2f5c53 Compare July 24, 2020 20:46

juippis reviewed Aug 5, 2020

View reviewed changes

juippis reviewed Aug 7, 2020

View reviewed changes

GuillaumeSeren mentioned this pull request Aug 7, 2020

notmuch dropped old python module in notmuch-0.30, fixed pazz/alot#1539

Open

GuillaumeSeren force-pushed the mail-client/alot-add-version-bump-0.9.1 branch from f2f5c53 to bee4e2b Compare August 7, 2020 10:03

GuillaumeSeren force-pushed the mail-client/alot-add-version-bump-0.9.1 branch 2 times, most recently from 891a691 to 09f891e Compare August 7, 2020 10:32

dev-python/urwidtrees: Add version bump 1.0.3

e96896e

Closes: https://bugs.gentoo.org/732360 Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

GuillaumeSeren force-pushed the mail-client/alot-add-version-bump-0.9.1 branch from 09f891e to 41c8b7e Compare August 8, 2020 17:11

GuillaumeSeren added 4 commits August 8, 2020 22:13

mail-client/alot: Add version bump 0.9.1

d4fa9b7

Closes: https://bugs.gentoo.org/732362 Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

mail-client/alot: Clean old version 0.8.1

5fbceae

Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

dev-python/urwidtrees: Add myself as maintainer

19af410

Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Guillaume Seren <[email protected]>

dev-python/urwid: Add fix locale patch

024c4bb

Closes: https://bugs.gentoo.org/736410 Package-Manager: Portage-2.3.99, Repoman-2.3.2 Signed-off-by: Guillaume Seren <[email protected]>

dev-python/urwid: Add version bump 2.1.1

7ebb35f

Closes: https://bugs.gentoo.org/736412 Package-Manager: Portage-2.3.99, Repoman-2.3.2 Signed-off-by: Guillaume Seren <[email protected]>

GuillaumeSeren force-pushed the mail-client/alot-add-version-bump-0.9.1 branch from 41c8b7e to 7ebb35f Compare August 8, 2020 20:15

juippis approved these changes Aug 9, 2020

View reviewed changes

GuillaumeSeren closed this Aug 26, 2020

mail-client/alot: Add version bump 0.9.1 #16680

mail-client/alot: Add version bump 0.9.1 #16680

Conversation

GuillaumeSeren commented Jul 12, 2020

gentoo-bot commented Jul 12, 2020

Pull Request assignment

Linked bugs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jul 12, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jul 19, 2020

Pull request CI report

gentoo-repo-qa-bot commented Jul 24, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Aug 7, 2020

Pull request CI report

gentoo-repo-qa-bot commented Aug 7, 2020

Pull request CI report

gentoo-repo-qa-bot commented Aug 7, 2020

Pull request CI report

GuillaumeSeren commented Aug 8, 2020

gentoo-repo-qa-bot commented Aug 8, 2020

Pull request CI report

janko-j1 commented Aug 8, 2020

GuillaumeSeren commented Aug 8, 2020

GuillaumeSeren commented Aug 8, 2020

gentoo-repo-qa-bot commented Aug 8, 2020

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillaumeSeren commented Aug 9, 2020 • edited Loading

GuillaumeSeren commented Aug 26, 2020

GuillaumeSeren commented Aug 9, 2020 •

edited

Loading