-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-biology/imagej: bump version imagej sources and plugins #1227
Conversation
IAHM-COL
commented
Dec 19, 2023
- ImageJ version bump 1.53t to 1.54g from NIH sources
- plugins version bump 153 to 154
* ImageJ version bump 1.53t to 1.54g from NIH sources * plugins version bump 153 to 154 Signed-off-by: IAHMCOL <[email protected]>
@AndrewAmmerlaan This continues the imagej version bumping. There are a few circumstances to be mentioned.
With all this in consideration, I think the version bump is clear for this merge request. |
What is the reason we need an ebuild for both locations? Is there some difference in the source files? |
I don't know the answer. I presume, downloading from both sites and running a SHA sum can answer whether the github releases and the source zips on the NIH site are actually mirrors. If you want I can test this for 1.54h. it's too involved to check for many versions. The NIH site kept the source dir outdated for a significant amount of time, and the releases appeared as tags on github. But they appear to be caught up now. |
That's the sha512s I am getting after downloading the zips from each source |
After unzipping, I run the diff, for evaluating what's different. FYI
|
Signed-off-by: IAHMCOL <[email protected]>
I think we can stick to one version, let's use this one that has the tests. |
I am ok with your call here. Let me update this pull request maintaining only the github sources. |
|
Thanks 👍 |
👍 |