PB-986 Cleanup obsolete SQL management scripts #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-986-remove-obsolete-sql-scripts
branch
2 times, most recently
from
a44de91 to
80587cf
Compare
boecklic
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Should we 'resque' this one somehow? E.g. transfer it into a mgmt command (executing raw sql), as existing commands to create dummy data are really slow for larger amount of objects (this sql script was created at the time in context of perf tests).
There was a problem hiding this comment.
Yes you're right.. the script is outdated though, it hasn't been updated since 2021. I'm gonna put it back with a big comment, so the next person who wants to do such a thing as loading random data will have to update it, but at least they have a good starting point. WDYT?
The SQL scripts aren't useful anymore. Some don't even work, as the DB structure has changed. The Database is now managed via Terraform, thus there's no need to have DB management scripts around.
The secrets file isn't used anymore. It was useful in conjunction with the SQL scripts that used to manage the DB
The script is outdated, as the models have new fields. We still want to keep the file as a starting point for future endeavors of adding random data to STAC
schtibe
force-pushed
the
feat-pb-986-remove-obsolete-sql-scripts
branch
from
0b68b23 to
39e720b
Compare
boecklic
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL scripts aren't useful anymore. Some don't even work, as the DB structure has changed.
The Database is now managed via Terraform, thus there's no need to have DB management scripts around.
Also removed the secrets.yml file, as this was necessary for the SQL scripts