PB 1358: fix issue with printing imported KMLS #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 44s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
ltkum
force-pushed
the
bugfix-PB-1358-cant-print-kmls
branch
from
3c0819b to
4362149
Compare
pakb
approved these changes
Jan 20, 2025
ltkum
force-pushed
the
bugfix-PB-1358-cant-print-kmls
branch
from
4362149 to
246ce1d
Compare
Issue : when trying to print imported kmls, we sometimes ran into an issue where there was no offset, and the printing service was not able to interpret a field not being present Fix : We now add a little line to ensure offsets exists in line when printing
ltkum
force-pushed
the
bugfix-PB-1358-cant-print-kmls
branch
from
246ce1d to
43df627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : when trying to print imported kmls, we sometimes ran into an issue where there was no offset, and the printing service was not able to interpret a field not being present
Fix : We now add a little line to ensure offsets exists in line when printing
Test link