PB-1377 : fix bug with line crossing Switzerland #1221
+1,923
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when drawing a line crossing without stop LV95 bounds, the function that was splitting this line into in and out chunks wasn't behaving properly (it needed at least one coordinate in to work well). I've switch the code splitting this up to use TurfJS function instead of a home-made one. Also switching to using the main TurfJS NPM entry, instead of importing each little pieces alone. Our bundler should do a good enough job of removing any part of the bigger package we don't use anyway.
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-PB-1377-fix-split-if-out-of-bounds
|
| Run status |
|
| Run duration | 05m 56s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
231
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/drawing.cy.js • 1 failed test • e2e/electron/mobile
| Test | Artifacts | |
|---|---|---|
| Drawing module tests > Drawing mode/tools > can create marker/icons and edit them |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when drawing a line crossing without stop LV95 bounds, the function that was splitting this line into in and out chunks wasn't behaving properly (it needed at least one coordinate in to work well).
I've switch the code splitting this up to use TurfJS function instead of a home-made one. Also switching to using the main TurfJS NPM entry, instead of importing each little pieces alone. Our bundler should do a good enough job of removing any part of the bigger package we don't use anyway.
Test link